Services: delete dead RelationshipService; rename persistence to snippet-persistence

src/app/services/RelationshipService.test.ts

@@ -1,72 +0,0 @@
-import { beforeEach, describe, expect, test } from 'vitest';
-import { createDataset } from '@core/dataset';
-import { createSnippet } from '@core/snippet';
-import { useDatasetStore } from '../stores/DatasetStore';
-import { useSnippetStore } from '../stores/SnippetStore';
-import {
-  datasetUsageCount,
-  findSnippetsReferencingDataset,
-  renameDatasetEverywhere,
-} from './RelationshipService';
-
-const T = new Date('2026-06-01T00:00:00Z');
-
-/** Seed a snippet whose published spec references `datasetName`. */
-function seedSnippet(id: string, datasetName: string) {
-  return createSnippet({
-    id,
-    spec: JSON.stringify({ data: { name: datasetName }, mark: 'bar' }),
-    now: T,
-  });
-}
-
-beforeEach(() => {
-  useDatasetStore.getState().reset();
-  useSnippetStore.getState().reset();
-});
-
-describe('reverse lookup', () => {
-  test('finds referencing snippets case-insensitively and counts them', () => {
-    useSnippetStore.getState().hydrate([seedSnippet('a', 'Sales'), seedSnippet('b', 'SALES')], 'a');
-    // datasetRefs are recomputed on publish; publish each active snippet to seed.
-    useSnippetStore.getState().publish(T);
-    useSnippetStore.getState().selectSnippet('b');
-    useSnippetStore.getState().publish(T);
-
-    expect(
-      findSnippetsReferencingDataset('sales')
-        .map((s) => s.id)
-        .sort(),
-    ).toEqual(['a', 'b']);
-    expect(datasetUsageCount('Sales')).toBe(2);
-    expect(datasetUsageCount('Other')).toBe(0);
-  });
-});
-
-describe('renameDatasetEverywhere', () => {
-  test('renames the dataset record and every referencing snippet', () => {
-    useDatasetStore.getState().add(
-      createDataset({
-        name: 'Sales',
-        data: [{ a: 1 }],
-        format: 'json',
-        source: 'inline',
-        now: T,
-      }),
-    );
-    useSnippetStore.getState().hydrate([seedSnippet('a', 'Sales')], 'a');
-    useSnippetStore.getState().publish(T);
-
-    const result = renameDatasetEverywhere('Sales', 'Revenue', new Date('2026-07-01T00:00:00Z'));
-
-    expect(result).toEqual({ updated: 1 });
-    expect(useDatasetStore.getState().datasets[0].name).toBe('Revenue');
-    const s = useSnippetStore.getState().snippets[0];
-    expect(s.datasetRefs).toEqual(['Revenue']);
-    expect(s.spec).toContain('"Revenue"');
-  });
-
-  test('is a no-op when old and new names are equal', () => {
-    expect(renameDatasetEverywhere('Sales', 'Sales')).toEqual({ updated: 0 });
-  });
-});

src/app/services/RelationshipService.ts

@@ -1,54 +0,0 @@
-/**
- * Snippet ↔ dataset relationships (docs/architecture/07 §4 + §6).
- *
- * The bidirectional link is name-based and has a single source of truth: a
- * snippet's `datasetRefs` (recomputed from its draft spec — the version being
- * edited — on every draft change and on publish). The reverse direction —
- * "which snippets use this dataset" — is therefore DERIVED by a scan,
- * never stored, so it can't drift. Rename is the one graph operation: it renames
- * the dataset record and propagates the new name into every referencing snippet's
- * spec/draftSpec/refs.
- *
- * These functions read and mutate Zustand stores, so they live in the app layer
- * (the pure rewrite/extraction helpers they build on live in `core/spec-refs`).
- */
-
-import type { Snippet } from '@core/snippet';
-import { snippetsReferencingDataset } from '@core/relationships';
-import { useDatasetStore } from '../stores/DatasetStore';
-import { useSnippetStore } from '../stores/SnippetStore';
-
-// The reverse-lookup scan itself is the pure `snippetsReferencingDataset`
-// (`core/relationships`) — the *one* implementation arch/07 §6 calls for. These
-// wrappers just bind it to a store snapshot for non-reactive callers (e.g. a
-// programmatic rename); the reactive UI calls the core helper directly with its
-// live `snippets` selection, so neither side duplicates the matching logic.
-
-/** Snippets whose `datasetRefs` include `name` (case-insensitive), from the store. */
-export function findSnippetsReferencingDataset(name: string): Snippet[] {
-  return snippetsReferencingDataset(useSnippetStore.getState().snippets, name);
-}
-
-/** Count for the dataset usage badge (spec §05 → List item). */
-export function datasetUsageCount(name: string): number {
-  return findSnippetsReferencingDataset(name).length;
-}
-
-/**
- * Rename a dataset and propagate everywhere (docs/architecture/07 §6): renames
- * the dataset record, then rewrites every referencing snippet's spec, draftSpec,
- * and datasetRefs (via `SnippetStore.renameDatasetRefs`, the single rename impl).
- * The caller is responsible for collision policy on `newName` (the edit form
- * rejects a taken name; programmatic paths pre-resolve a unique one). Returns the
- * number of snippets updated, as `{ updated }` (arch/07 §6).
- */
-export function renameDatasetEverywhere(
-  oldName: string,
-  newName: string,
-  now?: Date,
-): { updated: number } {
-  if (oldName === newName) return { updated: 0 };
-  const dataset = useDatasetStore.getState().datasets.find((d) => d.name === oldName);
-  if (dataset) useDatasetStore.getState().update(dataset.id, { name: newName }, now);
-  return { updated: useSnippetStore.getState().renameDatasetRefs(oldName, newName, now) };
-}