From f010ec6a3cf4c4ea4d87510aca8c3d4d641a1477 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 5 Aug 2026 13:40:59 +0000 Subject: [PATCH] Remove internal build decisions from visitor-facing content The public site (and DOM) shouldn't advertise our tooling choices: - Drop the design-system credit and typeface note from the footer; replace with visitor-useful copy ("Built to be sent" / "The canon") - Remove the external-inspiration reference from the homepage lede - Neutralize the meta description - Rename the `cds-` CSS class prefix to `site-` - Scrub internal names from source comments and the chart theme variable Functional font-family references are kept; only the advertising is removed. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01XPEvmMbac2fCvKXpQcovj8 --- src/components/VegaChart.astro | 22 +++++----- src/layouts/BaseLayout.astro | 33 +++++++-------- src/lib/charts.ts | 6 +-- src/pages/index.astro | 3 +- src/styles/global.css | 75 +++++++++++++++++----------------- 5 files changed, 67 insertions(+), 72 deletions(-) diff --git a/src/components/VegaChart.astro b/src/components/VegaChart.astro index b7e8c2f..f3471c5 100644 --- a/src/components/VegaChart.astro +++ b/src/components/VegaChart.astro @@ -1,13 +1,13 @@ --- -// Build-time Vega-Lite renderer, themed on Carbon. +// Build-time Vega-Lite renderer. // // Runs only during `astro build` (and dev SSR), never in the browser: it -// compiles a Vega-Lite spec to Vega with a Carbon theme (IBM Plex type + -// Carbon's data-visualization palette), renders it headlessly to a static SVG -// string, and inlines it. Zero client-side JavaScript, no Vega runtime shipped. +// compiles a Vega-Lite spec to Vega with the site theme, renders it headlessly +// to a static SVG string, and inlines it. Zero client-side JavaScript, no Vega +// runtime shipped. // -// The chart sits on a fixed light Carbon canvas (--chart-canvas) in both -// themes, so this single baked render keeps AA contrast in light and dark. +// The chart sits on a fixed light canvas (--chart-canvas) in both themes, so +// this single baked render keeps AA contrast in light and dark. import * as vega from 'vega'; import { compile, type TopLevelSpec, type Config } from 'vega-lite'; @@ -19,8 +19,8 @@ interface Props { const { spec, title, caption } = Astro.props; -// Carbon Vega theme — the design-system parameters the renderer consumes. -const carbonTheme: Config = { +// Chart theme — the visual parameters the renderer consumes. +const chartTheme: Config = { font: 'IBM Plex Sans', background: 'transparent', view: { stroke: null }, @@ -54,8 +54,8 @@ const carbonTheme: Config = { titleColor: '#393939', symbolType: 'square', }, - // Carbon data-visualization categorical palette (validated: passes the - // dataviz colorblind/contrast checks on the --chart-canvas surface). + // Categorical palette (validated colorblind-safe/contrast on the + // --chart-canvas surface). range: { category: ['#8a3ffc', '#009d9a', '#fa4d56', '#0f62fe', '#24a148', '#d02670', '#b28600', '#1192e8'], }, @@ -65,7 +65,7 @@ let svg = ''; let error: string | null = null; try { - const vgSpec = compile(spec, { config: carbonTheme }).spec; + const vgSpec = compile(spec, { config: chartTheme }).spec; const view = new vega.View(vega.parse(vgSpec), { renderer: 'none' }).initialize(); svg = await view.toSVG(); view.finalize(); diff --git a/src/layouts/BaseLayout.astro b/src/layouts/BaseLayout.astro index ac7f8f8..dd3bca0 100644 --- a/src/layouts/BaseLayout.astro +++ b/src/layouts/BaseLayout.astro @@ -1,5 +1,5 @@ --- -// IBM Plex, self-hosted via @fontsource (no external requests) — Carbon's typeface. +// Self-hosted webfonts via @fontsource (no external requests). import '@fontsource/ibm-plex-sans/300.css'; import '@fontsource/ibm-plex-sans/400.css'; import '@fontsource/ibm-plex-sans/600.css'; @@ -12,7 +12,7 @@ interface Props { description?: string; } -const { title, description = 'A catalogue of data-visualization sins, styled on the Carbon Design System.' } = +const { title, description = 'A catalogue of data-visualization sins — the deceptive chart, why it misleads, and the honest fix.' } = Astro.props; --- @@ -27,12 +27,12 @@ const { title, description = 'A catalogue of data-visualization sins, styled on -
-
- +
+
+ Chart Sins / honest data-viz -